-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OS and K8s version support in README.md #488
Conversation
@sachinkumarsingh092 please have a look :)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit.lgtm otherwise.
123b8aa
649ecac
to
123b8aa
Compare
123b8aa
to
4018eae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4018eae
to
93b48c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Congrats @VibhorChinda for your first contribution 🎉 |
Thanks @sachinkumarsingh092 many more to go :)) Hope so hahahahah |
@VibhorChinda, VMware has approved your signed contributor license agreement. |
What this PR does / why we need it:
Added OS and K8s version support in README.md
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # #478
Additional information
Earlier BYOH supported only a single version of Ubuntu and k8s. But now we support multiple versions of these.
Here is the list of supported OS and k8s versions. Added the required section in the README.md
Special notes for your reviewer